Skip to content

🌱 Bump sigs.k8s.io/cluster-api/test to release-1.11 commit for e2e fixes #5758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 2 commits into from
Nov 26, 2025
Merged

🌱 Bump sigs.k8s.io/cluster-api/test to release-1.11 commit for e2e fixes #5758

k8s-ci-robot merged 2 commits into from
Nov 26, 2025

Conversation

@chrischdi
Copy link
Member

@chrischdi chrischdi commented Nov 21, 2025

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Bumps CAPI test-framework to include fix for clusterclass changes e2e test.

Follow-up fix for #5720

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Nov 21, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 21, 2025

/test help

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-e2e-blocking

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 21, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 21, 2025

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-clusterclass

@chrischdi
Copy link
Member Author

chrischdi commented Nov 21, 2025

/test pull-cluster-api-provider-aws-e2e-eks

@clebs
Copy link
Contributor

clebs commented Nov 21, 2025

/lgtm

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

@clebs: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

damdo
damdo reviewed Nov 21, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

LGTM label has been added.

Git tree hash: 7e8d22250e8ef5743ed06d60bae83a829c485ebd

damdo
damdo reviewed Nov 21, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @richardcase @dlipovetsky @AndiDog @Ankitasw @nrb

@damdo
Copy link
Member

damdo commented Nov 21, 2025 •
edited
Loading

Job was failing deemed to fail due to an unrelated flake (here)

/test pull-cluster-api-provider-aws-e2e

@damdo
Copy link
Member

damdo commented Nov 21, 2025

/hold

For testing to finish/pass

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 21, 2025

/test pull-cluster-api-provider-aws-e2e

@nrb nrb added this to the v2.10 milestone Nov 21, 2025
@richardcase
Copy link
Member

richardcase commented Nov 21, 2025

Subject to the e2e passing:

/approve

@damdo
Copy link
Member

damdo commented Nov 23, 2025

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@clebs
Copy link
Contributor

clebs commented Nov 23, 2025

/test pull-cluster-api-provider-aws-e2e

@clebs
Copy link
Contributor

clebs commented Nov 23, 2025

@damdo @chrischdi after so many attempts, we should consider some fundamental changes on how this test works. It takes very long to run and fail rate is extremely high.

@chrischdi
Copy link
Member Author

chrischdi commented Nov 25, 2025

/retest

1 similar comment
@chrischdi
Copy link
Member Author

chrischdi commented Nov 25, 2025

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2025
@chrischdi
Copy link
Member Author

chrischdi commented Nov 25, 2025

Bumped again, so it includes:

@chrischdi
Copy link
Member Author

chrischdi commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e

1 similar comment
@chrischdi
Copy link
Member Author

chrischdi commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e

@chrischdi
Copy link
Member Author

chrischdi commented Nov 25, 2025

/test pull-cluster-api-provider-aws-e2e

@chrischdi
Copy link
Member Author

chrischdi commented Nov 26, 2025

/retest

@chrischdi chrischdi mentioned this pull request Nov 26, 2025
Open
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e 6301be1 link false /test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

damdo
damdo reviewed Nov 26, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 26, 2025

LGTM label has been added.

Git tree hash: ae958cffbc5ad34c1dde24fc3e5b17998cc14b2b

@damdo
Copy link
Member

damdo commented Nov 26, 2025

This solves one of the e2e failure introduced by the bump (for more details see: #5769). Let's merge it

@damdo
Copy link
Member

damdo commented Nov 26, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3b302dd into kubernetes-sigs:main Nov 26, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@AndiDog AndiDog Awaiting requested review from AndiDog

@nrb nrb Awaiting requested review from nrb

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@richardcase richardcase

@nrb nrb

@AndiDog AndiDog

@dlipovetsky dlipovetsky

@damdo damdo

@Ankitasw Ankitasw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v2.10

Development

Successfully merging this pull request may close these issues.

9 participants

@chrischdi @k8s-ci-robot @clebs @damdo @richardcase @nrb @AndiDog @dlipovetsky @Ankitasw